Fix language reporting dialects as not supported #19116
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lle when navigating messages in Outlook Classic
Collaborator
Author
|
@CyrilleB79 , feel free to test this if you want. Otherwise, I'll mark this as ready to review in a few days. |
SaschaCowley
added
the
conceptApproved
seanbudd
changed the title
seanbudd
reviewed
Nov 3, 2025
seanbudd
reviewed
Nov 3, 2025
nvdaes
force-pushed
the
fixLanguageReporting
branch
from
de950bb to
9002ccd
Compare
seanbudd
reviewed
Nov 4, 2025
seanbudd
approved these changes
Nov 5, 2025
Collaborator
Author
|
I'll tested these changes again, and for me it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18876
Summary of the issue:
NVDA reports as not supported dialects not available in synthesizer languages, even when a fallback language can be switched to.
Description of user facing changes:
When a dialect is not available for the current synthesizer, but NVDA can switch to a fallback language, that dialect won't be reported as not supported.
Description of developer facing changes:
None
Description of development approach:
In the
languageIsSupportedfunction of theSynthDriverclass, if a language is not supported, search for the availability of a fallback language, defined asmainLanguage-mainLanguage, for example,fr-fr.Testing strategy:
With the autoLanguageSwitching option enabled, read text, and use a gesture to report the different languages, using this webpage with eSpeak which contain French Kanada, as suggested by @CyrilleB79:
https://codepen.io/nvdaes/pen/WbrXxZL
Also, check that regressions are not introduced, testing with the following webpage:
https://codepen.io/nvdaes/pen/KwKyVpR
Known issues with pull request:
None
Code Review Checklist: